forked from dalek-cryptography/curve25519-dalek
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CI: fix minimal-versions resolution (dalek-cryptography#593)
To avoid nightly regressions breaking the build, the CI configuration has been updated to *only* use nightly for resolving Cargo.lock by using `cargo update -Z minimal-versions`. Previously, it was running `cargo check` which would attempt to compile all of the dependencies and the code, which is why the diagnostic bug was triggered. By avoiding any kind of code compilation using nightly we can avoid such regressions in the future. Additionally, the clippy job has been changed to run on the latest stable release (1.73.0) rather than nightly, which will prevent future clippy lints from breaking the build. Instead, they can be addressed when clippy is updated.
- Loading branch information
Showing
4 changed files
with
7 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,10 +134,9 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| # First run `cargo +nightly -Z minimal-verisons check` in order to get a | ||
| # Cargo.lock with the oldest possible deps | ||
| # Re-resolve Cargo.lock with minimal versions | ||
| - uses: dtolnay/rust-toolchain@nightly | ||
| - run: cargo -Z minimal-versions check --no-default-features --features serde | ||
| - run: cargo update -Z minimal-versions | ||
| # Now check that `cargo build` works with respect to the oldest possible | ||
| # deps and the stated MSRV | ||
| - uses: dtolnay/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,10 +24,9 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| # Now run `cargo +nightly -Z minimal-verisons check` in order to get a | ||
| # Cargo.lock with the oldest possible deps | ||
| # Re-resolve Cargo.lock with minimal versions | ||
| - uses: dtolnay/rust-toolchain@nightly | ||
| - run: cargo -Z minimal-versions check --no-default-features --features serde | ||
| - run: cargo update -Z minimal-versions | ||
| # Now check that `cargo build` works with respect to the oldest possible | ||
| # deps and the stated MSRV | ||
| - uses: dtolnay/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,10 +24,9 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| # Now run `cargo +nightly -Z minimal-verisons check` in order to get a | ||
| # Cargo.lock with the oldest possible deps | ||
| # Re-resolve Cargo.lock with minimal versions | ||
| - uses: dtolnay/rust-toolchain@nightly | ||
| - run: cargo -Z minimal-versions check --no-default-features --features serde | ||
| - run: cargo update -Z minimal-versions | ||
| # Now check that `cargo build` works with respect to the oldest possible | ||
| # deps and the stated MSRV | ||
| - uses: dtolnay/[email protected] | ||
|
|
||