Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser]: gRPC #16

Closed
jmcdo29 opened this issue Mar 28, 2020 · 0 comments · Fixed by #50
Closed

[Parser]: gRPC #16

jmcdo29 opened this issue Mar 28, 2020 · 0 comments · Fixed by #50
Labels
enhancement 🐺 A new feature to be implemented good first issue 👍 Good for newcomers gRPC A problem with the gRPC Parser help wanted 🆘 Extra attention is needed
Milestone
@ogma/namespace

Comments

@jmcdo29
Copy link
Owner

jmcdo29 commented Mar 28, 2020

Now that the core functionality has been re-written, it would be great to actually include gRPC in the request logging.

Looking for: package under the name @ogma/platform-grpc that exports a class GrpcInterceptorParser that extends AbstractInterceptorService from the @ogma/nestjs-module package.

The output of this is still to be determined. Some values may need to be hard-coded
@jmcdo29 jmcdo29 added help wanted 🆘 Extra attention is needed good first issue 👍 Good for newcomers enhancement 🐺 A new feature to be implemented gRPC A problem with the gRPC Parser labels Mar 28, 2020
@jmcdo29 jmcdo29 added this to the @ogma/namespace milestone Mar 28, 2020
@jmcdo29 jmcdo29 changed the title [Parser]: gRPC Parser [Parser]: gRPC Mar 28, 2020
jmcdo29 added a commit that referenced this issue May 25, 2020
@jmcdo29
feat(grpc): implements the grpc parser
1821d6e 
I'm not 100% sure of what data should be returned from the grpc parser, but this gets a basic
implementation until we can get more feedback on it.

fix #16
@jmcdo29 jmcdo29 mentioned this issue May 25, 2020
Merged
jmcdo29 added a commit that referenced this issue May 25, 2020
@jmcdo29
feat(grpc): implements the grpc parser
b4fc770 
I'm not 100% sure of what data should be returned from the grpc parser, but this gets a basic
implementation until we can get more feedback on it.

fix #16
jmcdo29 added a commit that referenced this issue Jun 20, 2021
@jmcdo29
feat(grpc): implements the grpc parser
ca917de 
I'm not 100% sure of what data should be returned from the grpc parser, but this gets a basic
implementation until we can get more feedback on it.

fix #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🐺 A new feature to be implemented good first issue 👍 Good for newcomers gRPC A problem with the gRPC Parser help wanted 🆘 Extra attention is needed
Projects
None yet
Milestone
@ogma/namespace
Development

Successfully merging a pull request may close this issue.

feat(grpc): implements the grpc parser jmcdo29/ogma
1 participant
@jmcdo29