feat(logger): logger will not print function names when objects have …

…funcs
jmcdo29 · Sep 12, 2020 · c496d16 · c496d16
1 parent 26dcd25
commit c496d16
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/packages/logger/src/logger/ogma.ts b/packages/logger/src/logger/ogma.ts
@@ -85,7 +85,8 @@ export class Ogma {
         return this.wrapInBrackets(value.toString());
       }
       if (typeof value === 'function') {
-        return this.wrapInBrackets('Function');
+        console.log(value);
+        return this.wrapInBrackets(`Function: ${value.name || '(anonymous)'}`);
       }
       if (typeof value === 'object' && value !== null) {
         if (seen.has(value)) {

diff --git a/packages/logger/test/ogma.spec.ts b/packages/logger/test/ogma.spec.ts
@@ -181,15 +181,10 @@ describe('Ogma Class', () => {
     ogma = new Ogma({ stream: mockStream });
     ogma.log(circularObject);
     expect(mockStream.write).toBeCalledTimes(1);
-    expect(mockStream.write.mock.calls[0][0]).toEqual(
-      expect.stringContaining('[Circular]'),
-    );
-    expect(mockStream.write.mock.calls[0][0]).toEqual(
-      expect.stringContaining('[Function]'),
-    );
-    expect(mockStream.write.mock.calls[0][0]).toEqual(
-      expect.stringContaining('[Symbol(hello)]'),
-    );
+    const writeString = mockStream.write.mock.calls[0][0];
+    expect(writeString).toEqual(expect.stringContaining('[Circular]'));
+    expect(writeString).toEqual(expect.stringContaining('[Function:'));
+    expect(writeString).toEqual(expect.stringContaining('[Symbol(hello)]'));
   });
   it('should follow the context, application, and message of a json', () => {
     ogma = new Ogma({