Make 19.03-dind the default image #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... This commit forces the entrypoint of all nodes to dockerd instead of dockerd-entrypoint to disable TLS dcertificate generation as we don't want it in our case. It also forces the primary container to serve the api over port :2735
jlevesy
force-pushed
the
move-to-docker-1903
branch
2 times, most recently
from
0083807
to
4f17a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the default image as 19.03.
In order to support this and be retro compatible, we needed to do the following things:
WithAPINegociationinstead of forcing an API version.I also bumped the tooling and fixed various lint issues