Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare sind for 1.0 #43

Merged
merged 32 commits into from
Jun 17, 2019
Merged

Prepare sind for 1.0 #43

merged 32 commits into from
Jun 17, 2019

Conversation

jlevesy
Copy link
Owner

@jlevesy jlevesy commented Jun 12, 2019

This PR is a complete rewrite of sind

Fixes #39 #38 #37 #35

Features & Usage improvements

  • sind now only relies on the docker host and no longer on a config file
  • sind can now start and stop the clusters, avoiding to recreate them.
  • IP of containers are now fixed, to enable start and stop
  • sind inspect enables to inspect the current state of a cluster
  • sind push gets a new --file option enabling to push an already existing file generated by docker save
  • sind ls output is updated and displays node stats

Code

  • Faster integration suite, as most of the testing details has been moved to an unit test suite mostly on the pkg/sind/internal package.
  • API has been broken, to enable users to inject their own docker client instance.

TODO

  • Backport and test sind ls
  • Backport sind push and support the --file option
  • Impement sind inspect
  • Bonus: support a --tmpfs flag on sind create for faster io on nodes.

@jlevesy jlevesy marked this pull request as ready for review June 17, 2019 17:46
@jlevesy jlevesy merged commit 5c38e83 into master Jun 17, 2019
@jlevesy jlevesy deleted the rewrite branch June 17, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flag --file to allow "sind push" to use a local file instead of a docker image
1 participant