eslint fixes (DeviaVir#1298)

jjude80 · Feb 7, 2018 · 2758400 · 2758400
1 parent 7139305
commit 2758400
Show file tree

Hide file tree

Showing 57 changed files with 714 additions and 738 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1,5 @@
+scripts/auto_backtester/node_modules/*
+scripts/genetic_backtester/node_modules/*
+scripts/genetic_algo/node_modules/*
+dist
+templates/dashboard_assets/js/*
diff --git a/.eslintrc b/.eslintrc
@@ -2,7 +2,8 @@
     "env": {
         "es6": true,
         "node": true,
-        "jasmine": true
+        "jasmine": true,
+        "browser": true
     },
     "extends": "eslint:recommended",
     "rules": {
@@ -23,5 +24,11 @@
             "error",
             "never"
         ]
+    },
+    "parserOptions": {
+        "sourceType": "module",
+        "ecmaFeatures": {
+            "experimentalObjectRestSpread": true
+        }
     }
 }
diff --git a/boot.js b/boot.js
@@ -16,7 +16,7 @@ module.exports = function (cb) {
     cb(null, zenbot)
   }
 
-  var authStr = '', authMechanismStr, authMechanism
+  var authStr = '', authMechanism
 
   if(c.mongo.username){
     authStr = encodeURIComponent(c.mongo.username)

diff --git a/commands/backfill.js b/commands/backfill.js
@@ -141,12 +141,13 @@ module.exports = function (program, conf) {
                     marker.newest_time = other_marker.newest_time
                   }
                 })
+                var diff
                 if (oldest_time !== marker.oldest_time) {
-                  var diff = tb(oldest_time - marker.oldest_time).resize('1h').value
+                  diff = tb(oldest_time - marker.oldest_time).resize('1h').value
                   console.log('\nskipping ' + diff + ' hrs of previously collected data')
                 }
                 else if (newest_time !== marker.newest_time) {
-                  var diff = tb(marker.newest_time - newest_time).resize('1h').value
+                  diff = tb(marker.newest_time - newest_time).resize('1h').value
                   console.log('\nskipping ' + diff + ' hrs of previously collected data')
                 }
                 resume_markers.save(marker, function (err) {

diff --git a/commands/backfill/backfill.function.js b/commands/backfill/backfill.function.js
@@ -16,7 +16,7 @@ module.exports = function container (conf) {
     cpService.setOnProcessFunc(backfillProcessFunction(conf))
     cpService.setAfterOnProcessFunc(backfillUpdateScreenFunction)
 
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve/*, reject*/) => {
       cpService.go(targetTimeInMillis).then((finalTrade) => {
         resolve(finalTrade)
       })

diff --git a/commands/backfill/backfill.process.function.js b/commands/backfill/backfill.process.function.js
@@ -33,7 +33,7 @@ module.exports = function (conf) {
           if (skipToTradeId === curr.trade_id) {
             let lastTrade = curr
             let idx = {i: index}
-            collectionServiceInstance.getTrades().insert(curr).then((err, doc) => {
+            collectionServiceInstance.getTrades().insert(curr).then((/*err, doc*/) => {
               if (idx.i === trades.length) {
                 cb(null, false, lastTrade.trade_id, lastTrade) 
               }

diff --git a/commands/balance.js b/commands/balance.js
@@ -1,5 +1,6 @@
 var minimist = require('minimist')
   , n = require('numbro')
+  // eslint-disable-next-line no-unused-vars
   , colors = require('colors')
   , moment = require('moment')
   , engineFactory = require('../lib/engine')
@@ -34,7 +35,7 @@ module.exports = function (program, conf) {
       var engine = engineFactory(s, conf)
       function balance () {
         s.exchange.getBalance(s, function (err, balance) {
-          if (err) return cb(err)
+          if (err) throw err
           s.exchange.getQuote(s, function (err, quote) {
             if (err) throw err
 

diff --git a/commands/buy.js b/commands/buy.js
@@ -1,5 +1,6 @@
 var minimist = require('minimist')
   , n = require('numbro')
+  // eslint-disable-next-line no-unused-vars
   , colors = require('colors')
   , objectifySelector = require('../lib/objectify-selector')
   , engineFactory = require('../lib/engine')

diff --git a/commands/list-selectors.js b/commands/list-selectors.js
@@ -1,11 +1,12 @@
+// eslint-disable-next-line no-unused-vars
 var colors = require('colors'),
   fs = require('fs')
 
 module.exports = function (program) {
   program
     .command('list-selectors')
     .description('list available selectors')
-    .action(function (cmd) {
+    .action(function (/*cmd*/) {
       var exchanges = fs.readdirSync('./extensions/exchanges')
       exchanges.forEach(function(exchange){
         console.log(`${exchange}:`)

diff --git a/commands/list-strategies.js b/commands/list-strategies.js
@@ -1,11 +1,12 @@
 var fs = require('fs'),
+  // eslint-disable-next-line no-unused-vars
   colors = require('colors')
 
 module.exports = function (program, conf) {
   program
     .command('list-strategies')
     .description('list available strategies')
-    .action(function (cmd) {
+    .action(function (/*cmd*/) {
       var strategies = fs.readdirSync('./extensions/strategies')
       strategies.forEach((strategy) => {
         let strat = require(`../extensions/strategies/${strategy}/strategy`)

diff --git a/commands/sell.js b/commands/sell.js
@@ -1,5 +1,6 @@
 var minimist = require('minimist')
   , n = require('numbro')
+  // eslint-disable-next-line no-unused-vars
   , colors = require('colors')
   , objectifySelector = require('../lib/objectify-selector')
   , engineFactory = require('../lib/engine')

diff --git a/commands/sim.js b/commands/sim.js
@@ -8,7 +8,6 @@ var tb = require('timebucket')
   , objectifySelector = require('../lib/objectify-selector')
   , engineFactory = require('../lib/engine')
   , tradesCollection = require('../db/trades')
-  , _ = require('lodash')
 
 module.exports = function (program, conf) {
   program
@@ -89,7 +88,7 @@ module.exports = function (program, conf) {
       var query_start = so.start ? tb(so.start).resize(so.period_length).subtract(so.min_periods + 2).toMilliseconds() : null
 
       function exitSim () {
-          console.log()
+        console.log()
         if (!s.period) {
           console.error('no trades found! try running `zenbot backfill ' + so.selector.normalized + '` first')
           process.exit(1)
@@ -105,8 +104,8 @@ module.exports = function (program, conf) {
           options[k] = so[k]
         })
 
-          let options_output = options
-          options_output.simresults = {}
+        let options_output = options
+        options_output.simresults = {}
 
         if (s.my_trades.length) {
           s.my_trades.push({
@@ -202,29 +201,29 @@ module.exports = function (program, conf) {
         process.exit(0)
       }
 
-        function getNext () {
-          var opts = {
-            query: {
-              selector: so.selector.normalized
-            },
-            sort: {time: 1},
-            limit: 1000
-          }
-          if (so.end) {
-            opts.query.time = {$lte: so.end}
-          }
-          if (cursor) {
-            if (reversing) {
-              opts.query.time = {}
-              opts.query.time['$lt'] = cursor
-              if (query_start) {
-                opts.query.time['$gte'] = query_start
-              }
-              opts.sort = {time: -1}
+      function getNext () {
+        var opts = {
+          query: {
+            selector: so.selector.normalized
+          },
+          sort: {time: 1},
+          limit: 1000
+        }
+        if (so.end) {
+          opts.query.time = {$lte: so.end}
+        }
+        if (cursor) {
+          if (reversing) {
+            opts.query.time = {}
+            opts.query.time['$lt'] = cursor
+            if (query_start) {
+              opts.query.time['$gte'] = query_start
             }
-            else {
-              if (!opts.query.time) opts.query.time = {}
-              opts.query.time['$gt'] = cursor
+            opts.sort = {time: -1}
+          }
+          else {
+            if (!opts.query.time) opts.query.time = {}
+            opts.query.time['$gt'] = cursor
           }
         }
         else if (query_start) {
@@ -240,26 +239,26 @@ module.exports = function (program, conf) {
               return getNext()
             }
             engine.exit(exitSim)
-            }
-            if (so.symmetrical && reversing) {
-              trades.forEach(function (trade) {
-                trade.orig_time = trade.time
-                trade.time = reverse_point + (reverse_point - trade.time)
-              })
-            }            
-            engine.update(trades, function (err) {
-              if (err) throw err
-              if (reversing) {
-                cursor = trades[trades.length - 1].orig_time
-              }
-              else {
-                cursor = trades[trades.length - 1].time
-              }
-              setImmediate(getNext)
+          }
+          if (so.symmetrical && reversing) {
+            trades.forEach(function (trade) {
+              trade.orig_time = trade.time
+              trade.time = reverse_point + (reverse_point - trade.time)
             })
+          }            
+          engine.update(trades, function (err) {
+            if (err) throw err
+            if (reversing) {
+              cursor = trades[trades.length - 1].orig_time
+            }
+            else {
+              cursor = trades[trades.length - 1].time
+            }
+            setImmediate(getNext)
           })
-        }
-        getNext()
-      })
-  }
+        })
+      }
+      getNext()
+    })
+}
 
diff --git a/commands/train.js b/commands/train.js
@@ -1,10 +1,10 @@
 var tb = require('timebucket')
   , minimist = require('minimist')
-  , n = require('numbro')
   , fs = require('fs')
   , path = require('path')
   , spawn = require('child_process').spawn
   , moment = require('moment')
+  // eslint-disable-next-line no-unused-vars
   , colors = require('colors')
   , analytics = require('forex.analytics')
   , ProgressBar = require('progress')
@@ -86,7 +86,7 @@ module.exports = function (program, conf) {
       if (!so.days_test) { so.days_test = 0 }
       so.strategy = 'noop'
 
-      unknownIndicators = []
+      var unknownIndicators = []
       if (so.indicators) {
         so.indicators.split(',').forEach(function(indicator) {
           if (!fa_availableIndicators.includes(indicator))
@@ -194,7 +194,7 @@ module.exports = function (program, conf) {
         var simulationResult = fs.readFileSync(simulationResultFile).toString()
         simulationResult = simulationResult.substr(simulationResult.length - 512)
 
-        result = {}
+        var result = {}
         if (simulationResult.match(endBalance)) { result.endBalance      = simulationResult.match(endBalance)[1] }
         if (simulationResult.match(buyHold))    { result.buyHold         = simulationResult.match(buyHold)[1] }
         if (simulationResult.match(vsBuyHold))  { result.vsBuyHold       = simulationResult.match(vsBuyHold)[1] }
@@ -300,7 +300,7 @@ module.exports = function (program, conf) {
           }
         )
 
-        return analytics.findStrategy(candlesticks, fa_getTrainOptions(so), function(strategy, fitness, generation) {
+        return analytics.findStrategy(candlesticks, fa_getTrainOptions(so), function(strategy, fitness/*, generation*/) {
           bar.tick({
             'fitness': fitness
           })
@@ -316,7 +316,6 @@ module.exports = function (program, conf) {
         }
 
         var option_keys = Object.keys(so)
-        var output_lines = []
         option_keys.sort(function (a, b) {
           if (a < b) return -1
           return 1

diff --git a/conf-sample.js b/conf-sample.js
@@ -232,7 +232,7 @@ c.notifiers.pushover.priority = '0' // choose a priority to send zenbot messages
 // end pushover configs
 
 // telegram configs
-c.notifiers.telegram = {};
+c.notifiers.telegram = {}
 c.notifiers.telegram.on = false // false telegram disabled; true telegram enabled (key should be correct)
 c.notifiers.telegram.bot_token = 'YOUR-BOT-TOKEN'
 c.notifiers.telegram.chat_id = 'YOUR-CHAT-ID' // the id of the chat the messages should be send in

diff --git a/extensions/exchanges/binance/exchange.js b/extensions/exchanges/binance/exchange.js
@@ -1,9 +1,8 @@
 const ccxt = require('ccxt')
   , path = require('path')
+  // eslint-disable-next-line no-unused-vars
   , colors = require('colors')
-  , moment = require('moment')
   , _ = require('lodash')
-  , n = require('numbro')
 
 module.exports = function bittrex (conf) {
   var public_client, authed_client