Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font #405

Closed
wants to merge 2 commits into from
Closed

Fix font #405

wants to merge 2 commits into from

Conversation

gmckeown
Copy link
Contributor

Proposed fix for #401.

@gmckeown
Copy link
Contributor Author

Although I've run the gulp script to generate the fonts, it looks like there's something more needed in order for this to work in Atom -- have just tested and the icons just show up as coloured rectangles...

Sorry, because I'm looking at this because of the icons in VS Code, I didn't initially consider testing it in Atom! In VS Code, with a little tweaking of the theme JSON, the icons in the WOFF are showing up.

@gmckeown
Copy link
Contributor Author

gmckeown commented Mar 23, 2017

OK, well I managed to do some fresh testing with a new install of Atom this evening, and I guess something may have been screwed up with the old install (maybe doesn't help that I'm just replacing files in the package folder and restarting Atom). New fonts are working just fine now, though be aware that the file-sizes are now bigger than the original font-files.

Here's what they looked like before the update:
atom_old_icons

And here's what they look like now:
atom_new_icons

I don't know whether you have any more exhaustive testing you run through to check things out, but I just want to be clear that my testing here has been pretty limited.

@gmckeown
Copy link
Contributor Author

Closing this one in favour of #406 .

@gmckeown gmckeown closed this Mar 23, 2017
@gmckeown gmckeown deleted the fix-font branch May 17, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant