twosigma#7515 fix widget is not attached error in TableDisplay.destroy (

twosigma#7516)
jdavidheiser · Jun 12, 2018 · 4520316 · 4520316
1 parent fe75cc7
commit 4520316
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/js/notebook/src/tableDisplay/dataGrid/BeakerXDataGrid.ts b/js/notebook/src/tableDisplay/dataGrid/BeakerXDataGrid.ts
@@ -197,7 +197,6 @@ export class BeakerXDataGrid extends DataGrid {
     this.highlighterManager.destroy();
     this.dataGridResize.destroy();
     this.rowManager.destroy();
-    this.dispose();
 
     Signal.disconnectAll(this);
 

diff --git a/js/notebook/src/tableDisplay/dataGrid/column/ColumnFilter.ts b/js/notebook/src/tableDisplay/dataGrid/column/ColumnFilter.ts
@@ -92,17 +92,13 @@ export default class ColumnFilter {
   }
 
   destroy(): void {
-    this.filterWidget.dispose();
-
-    setTimeout(() => {
-      this.dataGrid = null;
-      this.column = null;
-      this.filterWidget = null;
-      this.filterNode = null;
-      this.filterIcon = null;
-      this.clearIcon = null;
-      this.filterInput = null;
-    });
+    this.dataGrid = null;
+    this.column = null;
+    this.filterWidget = null;
+    this.filterNode = null;
+    this.filterIcon = null;
+    this.clearIcon = null;
+    this.filterInput = null;
   }
 
   private updateInputPosition() {