Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete avatars from file storage when avatar is deleted #174

Merged

Conversation

rafiqhilali
Copy link
Contributor

@rafiqhilali rafiqhilali commented Feb 8, 2019

fixes #175

@coveralls
Copy link

coveralls commented Feb 8, 2019

Coverage Status

Coverage decreased (-0.5%) to 84.926% when pulling d2004d0 on rafiqhilali:delete-avatars-from-file-storage into 182e7aa on grantmcconnaughey:master.

@johanneswilm
Copy link
Member

@grantmcconnaughey Will you be merging this?

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #174 (7e8c1a0) into main (1dd9933) will decrease coverage by 1.51%.
The diff coverage is 0.00%.

❗ Current head 7e8c1a0 differs from pull request most recent head f47f1ff. Consider uploading reports for the commit f47f1ff to get more accurate results

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   84.61%   83.10%   -1.52%     
==========================================
  Files          13       13              
  Lines         572      574       +2     
==========================================
- Hits          484      477       -7     
- Misses         88       97       +9     
Impacted Files Coverage Δ
avatar/models.py 80.95% <0.00%> (-5.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johanneswilm johanneswilm merged commit 8017d6f into jazzband:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatars not deleted from file storage when a user requests to delete an avatar
3 participants