Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVATAR_EXPOSE_USERNAMES still exposes usernames through <img alt=> #188

Closed
patrickscottbest opened this issue Jul 11, 2020 · 0 comments
Closed

AVATAR_EXPOSE_USERNAMES still exposes usernames through <img alt=> #188

patrickscottbest opened this issue Jul 11, 2020 · 0 comments

Comments

@patrickscottbest
Copy link

Although the URL no longer exposes usernames, the "alt" still betrays the intention of this control.

In this case, my user's PK is 1, and the username is "admin". This could have security implications.

 <img src="http://example.com/avatars/1/resized/80/1439577525067.jpg" width="80" height="80" alt="admin">
patrickscottbest added a commit to patrickscottbest/django-avatar that referenced this issue Jul 13, 2020
@patrickscottbest
Respect AVATAR_EXPOSE_USERNAMES for img alt
4678144 
This will prevent scraping "alts" for valid site usernames.
Submitted for jazzband#188
@patrickscottbest patrickscottbest mentioned this issue Jul 13, 2020
Closed
johanneswilm added a commit that referenced this issue Aug 10, 2022
@johanneswilm
Don't expose user names through alt tags, solves #189, solves #188, r…
7d276ea 
…elates to #181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johanneswilm @patrickscottbest