Fix a typo causing module.paths to be always set as the cwd. #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`options.fileName` was used instead of `options.filename`.
jashkenas
added a commit
that referenced
this pull request
Jan 29, 2014
Fix a typo causing module.paths to be always set as the cwd.
|
How bad is this bug? What's the observed broken behavior? |
|
We have a package called benbria-build which has all our common build tools in it. When we run: Then foo.coffee complains that it can't find modules in ./node_modules/benbria-build/node_modules. |
|
@michaelficarra ... feel like kicking the tires on your newfound ability to cut point releases? |
|
In theory, any time you run "coffee some-other-path/foo", you could run into this problem. |
|
Oh boy, this isn't a good one. @jashkenas: Yeah, I should have time to cut a point release this evening. |
|
Is there a good way to add a test for this? And is there anything else anyone's noticed that should go into a quick point release? |
|
Working on the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.fileNamewas used instead ofoptions.filename.