Packaging modernisation #305
Conversation
- Add a pyproject.toml file (with setuptools_scm, so that pypa-build will include everything from SCM in the build; and remove MANIFEST.in) - Move all the metadata from setup.py to setup.cfg (setup.py is left just to support editable builds). - Use `attr:` in setup.cfg to get the version programmatically instead of repeating it. - Update my email address
distutils is going to be deprecated (PEP 632), and packaging is the recommended replacement. This does end up requiring that the redis server version is a valid PEP 440 string, but that's only relevant during the unit tests so if redis does go to a weird versioning scheme it won't affect users directly.
ludwigschwardt
left a comment
ludwigschwardt
left a comment
There was a problem hiding this comment.
I don't see a pyproject.toml...
| import distutils.version | ||
|
|
||
| import aioredis | ||
| import packaging.version |
There was a problem hiding this comment.
I would probably use the same scheme as all the other files (from packaging.version import Version), but that's a very minor suggestion.
There was a problem hiding this comment.
I wanted to avoid exposing a fakeredis.aioredis.Version. I know I could import it as _Version or something but that still wouldn't be consistent.
There was a problem hiding this comment.
All good. 👍🏾 I guessed so, but then thought that aioredis was an internal module of sorts.
There was a problem hiding this comment.
It's a public module. fakeredis._aioredis1 and fakeredis._aioredis2 are internal.
Thanks, I forgot to |
| @@ -0,0 +1,2 @@ | |||
| [build-system] | |||
| requires = ["setuptools", "wheel", "setuptools-scm"] | |||
There was a problem hiding this comment.
Do you have to activate setuptools_scm beyond this line?
There was a problem hiding this comment.
It doesn't seem to need anything else: when I run python -m build . all the files end up in the sdist. I vaguely recall that the version handling needs activation, but I'm not using it.
will include everything from SCM in the build; and remove MANIFEST.in)
just to support editable builds).
attr:in setup.cfg to get the version programmatically insteadof repeating it.