Add support for SCRIPT EXISTS and SCRIPT FLUSH subcommands #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added support for the SCRIPT EXISTS subcommand in the SCRIPTS command handler. The subcommand takes in a sequence of sha1 hash values of Lua scripts and checks if scripts with those sha1 hash values are currently registered with Redis. The command will return a redis List with the integers 1 and 0 to indicate which sha1 hash is known to Redis. In accordance with Redis, this subcommand returns an empty List if no hash values were passed as arguments to the subcommand.
This commit adds support for the SCRIPT FLUSH subcommand which flushes all the loaded scripts from Redis. The subcommand takes no arguments and returns OK after completing its work.
bmerry
approved these changes
Oct 5, 2020
Collaborator
bmerry
left a comment
bmerry
left a comment
There was a problem hiding this comment.
Thanks, looks like good work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for
SCRIPT EXISTSandSCRIPT FLUSHand wrote tests for the new features. If there's anything you'd like to see changed, I'd be happy to implement those changes.