Handle indefinite timeout for PUBSUB commands #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmerry
approved these changes
Aug 15, 2020
Collaborator
bmerry
left a comment
bmerry
left a comment
There was a problem hiding this comment.
It looks good. I'm not sure why Coveralls is saying coverage decreased (it can't find the source file), so I'm going to assume that it's due to the Hypothesis tests being randomly seeded.
Contributor
Author
|
I would blame hypothesis as well. BTW, on my fork’s pipeline hypothesis produced some test cases pointing discrepancies between fake and real redis. Are you interested in receiving feedback with such test traces? |
Collaborator
|
Sure, file some bugs. I don't promise to do anything about it (particularly in the short term), but it's worth making a record when hypothesis occasionally finds a corner case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle indefinite timeout for
PUBSUBcommands.Indefinite timeout test is disabled for
py-redis3.2. This version introduced new default selector based onselect.poll, which itself supports indefinite polling via setting thetimeouttoNone, butpy-redisin this version scales thetimeoutby 1000 without type checking before passing it to the polling object, which renders this feature unavailable. Affected versions are 3.2.0 and 3.2.1, so the whole 3.2 family.Fixes #274