implement unlink command #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bmerry
requested changes
Aug 14, 2019
Collaborator
bmerry
left a comment
bmerry
left a comment
There was a problem hiding this comment.
Looks good. Can you just take out the bits that update the revision history and bump the version number. I prefer to do the version bump immediately before release.
Also can you add the unlink command to test_fakeredis_hypothesis.py (just search for where 'del' is currently handled).
Contributor
Author
|
Sure thing. I haven't used hypothesis before, so let me know if there's anything additional needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that a separate
_deletefunction was written due to the attr manipulation done ondel_which didn't allow for it to be called directly within unlink.