Support NX/XX/CH flags in ZADD command #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the new `NX`, `XX`, and `CH` flags in the `ZADD` command, which can only be provided with `redis-py` version 3 installed. This fixes a subset of what's filed in jamesls#232. `INCR` flag will be implemented in a different pull request, as it's completely different to handle.
bmerry
requested changes
Aug 14, 2019
Collaborator
bmerry
left a comment
bmerry
left a comment
There was a problem hiding this comment.
Thanks! Looks good, just a few suggestions for strengthening the tests.
test_fakeredis.py
Outdated
| self.assertEqual(self.zadd('foo', {'four': 4, 'three': 3, 'zero': 0}, xx=True), 0) | ||
| self.assertEqual(self.redis.zrange('foo', 0, -1), [b'three', b'four']) | ||
| self.assertEqual(self.zadd('foo', {'two': 2, 'one': 1}, xx=True), 0) | ||
| self.assertEqual(self.redis.zrange('foo', 0, -1), [b'three', b'four']) |
Collaborator
There was a problem hiding this comment.
Add a check that the scores do get updated.
Contributor
Author
There was a problem hiding this comment.
I refactored the tests to use zrange with scores, and made them a bit more programmatic, to improve readability. Let me know what you think!
Collaborator
There was a problem hiding this comment.
I'm happy with that approach. What do you think about using a namedtuple rather than a dict with fixed keys to store the update information?
Contributor
Author
There was a problem hiding this comment.
Updated to use namedtuples, thanks for the suggestion! Let me know if naming works for you :)
bmerry
approved these changes
Aug 26, 2019
Collaborator
|
Looks good. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the new
NX,XX, andCHflags in theZADDcommand, which can only be provided withredis-pyversion 3 installed.This fixes a subset of what's filed in #232.
INCRflag will be implemented in a different pull request, as it's completely different to handle.