Python 3.7 #222
Python 3.7 #222
Conversation
bmerry
left a comment
bmerry
left a comment
There was a problem hiding this comment.
Thanks for the 3.8 support!
I don't use pipenv myself, and currently I'm the only maintainer (in very limited spare time). Would you sign up to maintain the Pipfile? It shouldn't be much work since very little is happening on fakeredis, but I'd rather not add something that is immediately unmaintained.
|
@bmerry Added Explicit |
|
Great. Travis failed for some reason, but it doesn't seem like it's related to your change at all so I'm rerunning it. Assuming that passes I'll merge. @jamesls, if you're happy could you give @owenstranathan write access? It seems I don't have permission. |
|
I suspect the Python 3.7 problem is because Travis has switched to redis 5.0 (but presumably only on xenial, not trusty). Master is also failing. So I'm going to merge anyway. |
|
@owenstranathan I've got a branch called |
3 participants
It works out of the box. Only thing is deprecation warnings that are annoying in tests.
Given this:
https://docs.python.org/3/whatsnew/3.7.html#id3
Getting ABCs from
collectionsis depricated in 3.8 so this preemptively fixes that and also get rid of those pesky aforementioned deprecation warnings.Also adds a Pipfile for those of us who have adopted Pipenv.