Make __getitem__ raise a KeyError for missing keys #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In redis-py, attempting to use __getitem__ with a non-existent key causes a KeyError to be raised, while fakeredis returns None. This change makes it so that __getitem__ in fakeredis works the same way as in redis-py.
1 similar comment
Collaborator
|
Thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In redis-py, attempting to use getitem with a non-existent key
causes a KeyError to be raised, while fakeredis returns None. This
change makes it so that getitem in fakeredis works the same way as
in redis-py.
Fixes #191