Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessor for PU name to EntityManagerFactory #503

Closed
gavinking opened this issue Aug 26, 2023 · 1 comment · Fixed by #504
Closed

Add accessor for PU name to EntityManagerFactory #503

gavinking opened this issue Aug 26, 2023 · 1 comment · Fixed by #504

Comments

@gavinking
Copy link
Contributor

gavinking commented Aug 26, 2023 •
edited
Loading

Every persistence unit has a well-defined name in JPA.

So it would make sense to let you access it via EntityManagerFactory.getPersistenceUnitName() or even just EntityManagerFactory.getName().

This likely quite useful for generic (framework) code.
gavinking added a commit to gavinking/persistence that referenced this issue Aug 26, 2023
@gavinking
Add accessor for PU name to EntityManagerFactory
a8f860a 
see jakartaee#503
@gavinking gavinking mentioned this issue Aug 26, 2023
Merged
@gavinking gavinking linked a pull request Aug 26, 2023 that will close this issue
Add accessor for PU name to EntityManagerFactory #504
Merged
@dmatej
Copy link
Contributor

dmatej commented Aug 30, 2023

It is useful especially for some types of tests when devs spend time by investigating a "magic" when they just could use assertEquals("expectedPUName", em.getName()); to check they really work with the right entitymanager.
It could be useful also for logs.

lukasj pushed a commit that referenced this issue Sep 4, 2023
@gavinking @lukasj
Add accessor for PU name to EntityManagerFactory
ed441e8 
see #503
@github-project-automation github-project-automation bot moved this to Done in 3.2.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
3.2.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add accessor for PU name to EntityManagerFactory gavinking/persistence
2 participants
@dmatej @gavinking