Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move CriteriaQuery#getParameters() to CommonAbstractCriteria #155

Closed
lukasj opened this issue Aug 10, 2017 · 2 comments · Fixed by #441
Closed

move CriteriaQuery#getParameters() to CommonAbstractCriteria #155

lukasj opened this issue Aug 10, 2017 · 2 comments · Fixed by #441

Comments

@lukasj
Copy link
Contributor

lukasj commented Aug 10, 2017

I'd suggest moving the CriteriaQuery#getParameters() method to the CommonAbstractCriteria interface because parameters may be used on the CriteriaUpdate and the CriteriaDelete criterias as well on the common CriteriaQuery.

So I think we should have the same method on the all criteria types to get assigned parameters.
@lukasj
Copy link
Contributor Author

lukasj commented Aug 31, 2018

gavinking added a commit to gavinking/persistence that referenced this issue Aug 9, 2023
@gavinking
pull getParameters() up from CriteriaQuery to CommonAbstractCriteria
f5a8995 
see jakartaee#155.
@gavinking gavinking mentioned this issue Aug 9, 2023
Merged
gavinking added a commit to gavinking/persistence that referenced this issue Aug 9, 2023
@gavinking
pull getParameters() up from CriteriaQuery to CommonAbstractCriteria
adc34ad 
see jakartaee#155.
@gavinking
Copy link
Contributor

Fixed by #441.

@lukasj lukasj linked a pull request Aug 10, 2023 that will close this issue
pull getParameters() up from CriteriaQuery to CommonAbstractCriteria #441
Merged
gavinking added a commit to gavinking/persistence that referenced this issue Aug 10, 2023
@gavinking
pull getParameters() up from CriteriaQuery to CommonAbstractCriteria
28cdac1 
see jakartaee#155.
lukasj pushed a commit that referenced this issue Aug 10, 2023
@gavinking @lukasj
pull getParameters() up from CriteriaQuery to CommonAbstractCriteria
07ec56c 
see #155.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pull getParameters() up from CriteriaQuery to CommonAbstractCriteria gavinking/persistence
2 participants
@gavinking @lukasj