Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TABLE-generated IDs available on PrePersist #133

Closed
lukasj opened this issue Aug 9, 2016 · 8 comments · Fixed by #488
Closed

Make TABLE-generated IDs available on PrePersist #133

lukasj opened this issue Aug 9, 2016 · 8 comments · Fixed by #488
Labels
generator id lifecycle Priority: Minor Type: Improvement

Comments

@lukasj
Copy link
Contributor

lukasj commented Aug 9, 2016 •
edited by gavinking
Loading

JSR-338/3.5.3 states that

Generated primary key values are available in the PostPersist method.

It'll be much helpful if those ids whose strategy is GenerationType.TABLE are available on PrePersist.

exempli gratia

public class MyEntity {

    @PrePersist
    private void onPrePersist() {
        // generate a unique and unchangable value from *available* id.
        derived = String.format("%1$016x", id);
    }

    @GeneratedValue(..., strategy = GenerationType.TABLE)
    @Id
    private Long id;

    @Basic(optional = false)
    @Colum(..., nullable = false, updatable = false)
    @NotNull
    private String derived;
}

Note that the derived column is not null and not updatable.
@lukasj
Copy link
Contributor Author

lukasj commented Aug 9, 2016

@glassfishrobot Commented
Reported by jinahya

@lukasj
Copy link
Contributor Author

lukasj commented Aug 22, 2016

@glassfishrobot Commented
neilstockton said:
FWIW DataNucleus JPA already does set ids from all non-IDENTITY value generators (i.e TABLE, SEQUENCE, custom) prior to PrePersist, so hence the values are available in that method.

@lukasj
Copy link
Contributor Author

lukasj commented May 5, 2017

@glassfishrobot Commented
This issue was imported from java.net JIRA JPA_SPEC-133

@lukasj
Copy link
Contributor Author

lukasj commented Aug 31, 2018

@gavinking gavinking mentioned this issue Aug 22, 2023
Merged
@gavinking
Copy link
Contributor

This is a pretty reasonable and useful request, it seems to me, and to be honest I'm not sure why Hibernate didn't already do things this way (I guess nobody ever asked us directly). But anyway, looks like I've been able to get that working with a very straightforward change. So from our side I don't think we would have a problem adding it to the spec.

@lukasj WDYT? What does EclipseLink do here?

gavinking added a commit to gavinking/persistence that referenced this issue Aug 23, 2023
@gavinking
specify that SEQUENCE, TABLE, UUID generated ids are available in @Pr…
bcfcef3 
…ePersist

see jakartaee#133
@gavinking gavinking mentioned this issue Aug 23, 2023
Merged
@gavinking gavinking linked a pull request Aug 23, 2023 that will close this issue
specify that SEQUENCE, TABLE, UUID generated ids are available in @PrePersist #488
Merged
@gavinking
Copy link
Contributor

I have proposed #488. Let's see if other implementors object.

@lukasj
Copy link
Contributor Author

lukasj commented Aug 24, 2023

EclipseLink already supports this

@gavinking
Copy link
Contributor

OK, so I checked with the Hibernate team and they do not object to the change.

lukasj pushed a commit that referenced this issue Aug 24, 2023
@gavinking @lukasj
specify that SEQUENCE, TABLE, UUID generated ids are available in @Pr…
9e21c30 
…ePersist

see #133
@github-project-automation github-project-automation bot moved this to Done in 3.2.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
generator id lifecycle Priority: Minor Type: Improvement
Projects
3.2.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

specify that SEQUENCE, TABLE, UUID generated ids are available in @PrePersist gavinking/persistence
2 participants
@gavinking @lukasj