Get rid of cycle Offline → ConfigLoader.load → Offline.class #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
get_rid_of_cycle
branch
from
f6fdcea to
c18983e
Compare
|
@marchof I had a look at this cycle as a follow-up of #1822 (comment) and AFAICS this cycle has been there since the introduction of |
Godin
changed the title
Godin
force-pushed
the
get_rid_of_cycle
branch
from
c18983e to
2512e74
Compare
Godin
force-pushed
the
get_rid_of_cycle
branch
from
2512e74 to
e78827a
Compare
|
@marchof could you please review? |
marchof
approved these changes
Jan 13, 2025
marchof
force-pushed
the
get_rid_of_cycle
branch
from
e78827a to
26e269c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.