feat: extract wallet api to own service #90
Conversation
onbjerg
force-pushed
the
onbjerg/relay
branch
5 times, most recently
from
c42f838 to
a2bc7d6
Compare
crates/wallet/src/lib.rs
Outdated
| // err.into() | ||
| OdysseyWalletError::InvalidTransactionRequest |
There was a problem hiding this comment.
need to fix the error handling, it's a bit cumbersome to work with RpcResult using thiserror
| ProviderBuilder::new() | ||
| .with_recommended_fillers() | ||
| .wallet(wallet) | ||
| .on_client(rpc_client), | ||
| ctx.config().chain.chain().id(), |
There was a problem hiding this comment.
we could get rid of the chain id arg if we weren't dependent on integrating it into the sequencer also; in that case, the service could just fetch the chain id. but since we init the module here before the rpc server has started, this is not possible
onbjerg
force-pushed
the
onbjerg/relay
branch
2 times, most recently
from
621ea88 to
f7eb8c8
Compare
| /// The secret key to sponsor transactions with. | ||
| #[arg(long, value_name = "SECRET_KEY", env = "RELAY_SK")] | ||
| secret_key: String, |
There was a problem hiding this comment.
There was a problem hiding this comment.
great reference ty,
onbjerg
force-pushed
the
onbjerg/relay
branch
3 times, most recently
from
9e2a2f0 to
71b108b
Compare
onbjerg
force-pushed
the
onbjerg/relay
branch
6 times, most recently
from
0d37c7d to
26cac5e
Compare
onbjerg
force-pushed
the
onbjerg/relay
branch
from
26cac5e to
a35e85d
Compare
On top of #90
| /// The Odyssey relayer service sponsors transactions for EIP-7702 accounts. | ||
| #[derive(Debug, Parser)] | ||
| #[command(author, about = "Relay", long_about = None)] | ||
| struct Args { |
There was a problem hiding this comment.
maybe should be moved into the lib and be importable in odyssey binary with clap flatten under relayer.http.address, --relayer.signer etc.?
crates/wallet/src/lib.rs
Outdated
| /// The capability to perform [EIP-7702][eip-7702] delegations, sponsored by the sequencer. | ||
| /// A trait for any type capable of estimating, signing, and propagating sponsored transactions. | ||
| #[async_trait] | ||
| pub trait Node<N> |
There was a problem hiding this comment.
good separation
i wish didn't need a new trait and could just work w/ alloy provider traits?
There was a problem hiding this comment.
I agree, but then we'd have to implement alloy provider trait for reth's state provider which is a lot of work when we only need like 3-4 functions
onbjerg
force-pushed
the
onbjerg/relay
branch
4 times, most recently
from
e6844da to
d010d67
Compare
onbjerg
force-pushed
the
onbjerg/relay
branch
from
d010d67 to
7f3e8ab
Compare
onbjerg
force-pushed
the
onbjerg/relay
branch
from
7f3e8ab to
96aa0ad
Compare
Extracts the
wallet_namespace to its own standalone service in preparation for other things.Closes #94