Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Chinese fault injection #2421

Merged
merged 10 commits into from
Aug 31, 2018

Conversation

shaobai
Copy link
Contributor

@shaobai shaobai commented Aug 27, 2018

No description provided.

@istio-testing
Copy link
Contributor

Hi @shaobai. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaobai shaobai changed the title translate fault injection Translate Chinese fault injection Aug 27, 2018
Copy link
Member

@fleeto fleeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

服务名称和错误信息应保持原文

@fleeto fleeto added the translation/chinese Translation item label Aug 27, 2018
这些类型的错误可能发生在典型的企业应用程序中,其中不同的团队独立地开发不同的微服务。
Istio 的故障注入规则可帮助您识别此类异常,而不会影响最终用户。
你发现了一个 bug 。在微服务中有硬编码超时,导致 `reviews` 服务失败。
在 `productpage` 和 `reviews` 服务之间超时时间是 6s - 编码 3s + 1 重试总共 6s ,`reviews` 和 `ratings` 服务之间的硬编码连接超时为 10s 。由于我们引入的延时,`/productpage` 提前超时并引发错误。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

productpage 和 reviews 服务之间的超时时间是:6 秒剪掉编码 3 秒,加上一次重试,总计 6 秒。?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文:The timeout between the
productpage and the reviews service is 6 seconds - coded as 3s + 1 retry
for 6s total

@fleeto
Copy link
Member

fleeto commented Aug 31, 2018

/approve
/lgtm

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fleeto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 6de597c into istio:master Aug 31, 2018
@shaobai shaobai deleted the translate_fault_injection_index branch September 2, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants