This repository was archived by the owner on Feb 6, 2022. It is now read-only.
Rewrite to proper logic #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogierslag
force-pushed
the
rewrite
branch
2 times, most recently
from
9ab19f7 to
3fd7dee
Compare
| // When cropping, we size the image first to fix completely within the bounding box | ||
| // Then we crop the requested size, and center to the center of the image | ||
| const crop = async(client, params) => { | ||
| client = client.resize(params.width, params.height, '^'); |
There was a problem hiding this comment.
what is that ^ ? needs a comment
| } | ||
| } | ||
|
|
||
| // Check if the minimum is ste |
|
nice dude! |
| result.type = req.params.format.toLowerCase(); | ||
| result.mime = getMimeFromExtension(result.type); | ||
| } | ||
| if (req.query.fit && ALLOWED_FITS.includes(req.query.fit)) { |
There was a problem hiding this comment.
needs a .toLowerCase as well
|
Todo:
|
| }); | ||
| const S3 = new AWS.S3(); | ||
|
|
||
| const uploadPromise = (client, params) => { |
There was a problem hiding this comment.
uploadPromise isn't a promise. I'd just call it upload.
|
Nice work! I have quite a few comments, but all are minor. So definitely 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TiddoLangerak @wouter-willems @joostverdoorn Can I haz a first 👀 ? Did a small Tiddo and wanted to rewrite this to proper logic. This way the code does not hurt my eyes anymore.
The diff is terrible though, so you might be better off checking the branch itself.