This repository has been archived by the owner on Feb 6, 2022. It is now read-only.
Allow optional cropping of images while uploading #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! 👍 |
| @@ -267,7 +267,7 @@ const Image = { | |||
| // Upload the RAW image to disk, stripped of its extension | |||
| // First check the token | |||
| const sentToken = req.headers['x-token']; | |||
| const matches = req.url.match(/^\/(.*)\.([^.]+)$/); | |||
| const matches = req.path.match(/^\/(.*)\.([^.]+)$/); | |||
There was a problem hiding this comment.
Where does this change come from? Was this a bug?
There was a problem hiding this comment.
No this did work because of the format and constraints in the past. But yes it was a possible bug ;)
The url contains the full URL, including any query parameters. These were not used in the past, so never sent. The url was therefore equal to the path.
Since we now do accept query parameters, we want to save the file as test.jpg and not test.jpg?x=0&y=4&width=100&height=400 but still as test.jpg. The path variable contains exactly this
rogierslag
force-pushed
the
cropping-while-uploading
branch
from
d3bd2f7 to
95e5952
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @wouter-willems, setting the query parameters
x,y,widthandheightallow to crop the picture when uploading. This prevents cropping weirdness in the browser if we handle it using javascriptReady for review @TiddoLangerak @joostverdoorn @wouter-willems