feat: show graphql operation name for graphql requests #1521
Conversation
|
The contributing guide, unfortunately, doesn't specify who should be marked as the reviewer. |
morganick
left a comment
morganick
left a comment
There was a problem hiding this comment.
Sorry for such a long delay in this. I had a couple of moments this morning and had the tab still open 😅 I haven't had a chance to fully test this out with a GraphQL API & Apollo Client. I'll look at doing that next week.
lib/reactotron-core-ui/src/timelineCommands/ApiResponseCommand/index.tsx
Outdated
Show resolved
Hide resolved
|
@yurik256 thanks for the contribution! Do you have the time to make the requested changes by Nick? If not let us know and we can try to bring it up to speed. |
@frankcalise thanks for following up! I somehow missed the message from @morganick :( I tried changing the order so that we show the operation name before the URL, and that makes it visually hard to parse. operation name before: operation name after: |
|
@yurik256 I'm good with putting it after the URL. I'd love to update the design of the timeline to accommodate for things like this. It gets lost a bit either way, but I agree that after is easier on the eyes because of the uniformity of the pattern in |
|
Hey @morganick, I’ve made the changes you requested – could you take another look when you have a moment? |
## Please verify the following: - [x] `yarn build-and-test:local` passes ## Describe your PR This PR does a minor refactor to our electron-store usage to trigger a release for reactotron-app, to release this PR #1521
…tch docs (#1536) ## Please verify the following: - [x] yarn run v1.22.22 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. passes ## Describe your PR This PR does a minor refactor to our electron-store usage to trigger a release for reactotron-app, to release this PR infinitered/reactotron#1521 (cac1f298a81697ab62c8116a84c586e692319828)
3 participants
Please verify the following:
yarn build-and-test:localpassesREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
On the react native project I'm working on, we are extensively using graphql.
Current implement of timeline plugin, makes it hard to differentiate graphql requests, as they are all shown as
POST /graphqlin the timelineThis PR improves this by adding the following
request.operationNamefield, which is automatically added for all graphql requests made by@apollo/clientScreenshots
Show operation name
Ability to search by request data ( in this case, operation name )
