Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: CLI and binary build #472

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Feat: CLI and binary build #472

merged 3 commits into from
Jan 30, 2023

Conversation

simonecorsi
Copy link
Collaborator

🚨 Proposed changes

This feat wants to introduce:

  • CLI Capabilities
  • CI: builds cli as a binary to allow usage in non Node.js envs

⚙️ Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Refactor

@simonecorsi simonecorsi marked this pull request as draft January 23, 2023 15:50
@simonecorsi
Copy link
Collaborator Author

I'm not sure if I want to include the CLI on NPM or just made it available as a binary in the Github Releases, what your thoughts on this? @dnlup @antoniomuso

@dnlup
Copy link
Contributor

dnlup commented Jan 25, 2023

I'm not sure if I want to include the CLI on NPM or just made it available as a binary in the Github Releases, what your thoughts on this? @dnlup @antoniomuso

I am for making it available in the GH Releases

dnlup
dnlup previously approved these changes Jan 25, 2023
View reviewed changes
@simonecorsi
Copy link
Collaborator Author

simonecorsi commented Jan 27, 2023 •
edited
Loading

New feature: optionally we can use the file .datsrc to provide the flags that doesn't change (eg: host/port) for usage in runners

@simonecorsi simonecorsi changed the base branch from main to next January 27, 2023 16:00
@simonecorsi simonecorsi dismissed dnlup’s stale review January 27, 2023 16:00

The base branch was changed.

@dnlup
Copy link
Contributor

dnlup commented Jan 30, 2023

We are having some strange errors on Windows again 🤦🏻

@simonecorsi simonecorsi marked this pull request as ready for review January 30, 2023 15:59
@simonecorsi simonecorsi merged commit b4b228d into next Jan 30, 2023
@simonecorsi
Copy link
Collaborator Author

🎉 This PR is included in version 4.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@simonecorsi
Copy link
Collaborator Author

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dnlup dnlup deleted the feat/cli branch February 14, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlup dnlup dnlup left review comments

@antoniomuso antoniomuso Awaiting requested review from antoniomuso

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonecorsi @dnlup @antoniomuso