Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not auto freeze non-enumerable or symbolic properties #590

Closed
mweststrate opened this issue Apr 28, 2020 · 1 comment
Closed

Do not auto freeze non-enumerable or symbolic properties #590

mweststrate opened this issue Apr 28, 2020 · 1 comment
Labels
released

Comments

@mweststrate
Copy link
Collaborator

🐛 Bug Report

Non-enumerable or symbolic properties are often used by framework internals to associate some state with an immutable element. For example React associaties state to element instances this way. Not recursively freezing those will prevent accidental DEV breakages.

Link to repro

https://codesandbox.io/s/vigilant-morse-o2y5m?file=/src/index.js
mweststrate added a commit that referenced this issue May 5, 2020
@mweststrate
fix: Don't recurse into non-enumerable members when freezing tree. Fixes
497d1a0 
 #590
@aleclarson
Copy link
Member

🎉 This issue has been resolved in version 6.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweststrate @aleclarson