-
Notifications
You must be signed in to change notification settings - Fork 89
Upgrade Lokole's Python dependencies #3276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nzola Please test this PR by executing the following command: curl iiab.io/install.txt | sudo bash -s 3276 |
roles/lokole/tasks/install.yml
Outdated
- name: "OPTIONAL: pip install opwen_email_client (Lokole, git commit {{ lokole_commit }}) from GitHub to {{ lokole_venv }}, if lokole_commit is defined" | ||
pip: | ||
name: "git+https://github.com/ascoderu/lokole.git@{{ lokole_commit }}#egg=opwen_email_client" | ||
name: "git+https://github.com/mabuelhagag/lokole.git@{{ lokole_commit }}#egg=opwen_email_client" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary during testing, right?
(Presumably account 'mabuelhagag' will be changed back to 'ascoderu' later?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, until upstream is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might have to drop the 'git+' part and tinker with the rest of the string to get it right, but that is the general idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One could move the definition from hardcoded to softcoded and use local_vars to override.
pip:
name: "{{ lokole_repo }}"
then define in defaults/main.yml
lokole_repo: git+https://github.com/ascoderu/lokole.git@{{ lokole_commit }}#egg=opwen_email_client
and then use the override in local_vars.yml
lokole_repo: git+https://github.com/mabuelhagag/lokole.git@{{ lokole_commit }}#egg=opwen_email_client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if 191e757 does it
Think 'environment=OPWEN_SETTINGS={{ lokole_settings }}' is intended to read a single file holding the environment variables that starts out as templates/settings.env.j2, perhaps 'FLASK_APP="opwen_email_client.webapp:app"' could reside in settings.env.j2? |
Current PR as of e0ca1f2 works through to login with Admin, looks good so far. |
The registration webpage where lokole_client_id and auth token could be entered is gone. |
Flask CLI uses this environment var first to find the app, using the |
What does pointing to |
lol.. forgot 'Admin' and 'admin' makes a difference when logging in but only 'admin' is displayed on the logout button... logging in as 'admin' takes me straight to the registration page. Nice work. |
TASK [lokole : start supervisor] ************************************************************************************************************************************************************************************************************ TASK [lokole : Create Lokole admin user with password, for http://box/lokole] *************************************************************************************************************************************************************** TASK [lokole : SEE ERROR ABOVE (skip_role_on_error: False)] ********************************************************************************************************************************************************************************* PLAY RECAP ********************************************************************************************************************************************************************************************************************************** pi@raspberrypi:~ $ |
Thanks @nzola In general please also post the sprunge.us pastebin URL — after you run: iiab-diagnostics |
Looks like |
@nzola should try the following 3 lines to try to rescue his current install attempt:
No need to start over with a completely clean/fresh OS (hopefully!) |
@mabuelhagag @holta I did as recommended by @holta , but end up with the same error. See details: pi@raspberrypi:~ $ cd /opt/iiab/iiab
|
@nzola if you try this again, run:
|
@holta Ok I am going to run what you have just sent. But I have a question I originally used this command to install iiab : curl iiab.io/install.txt | sudo bash -s 3276 as directed.There is no d. before iiab does it matter? |
same error after I run this: pi@raspberrypi:/opt/iiab/iiab $ cd /opt/iiab/iiab
|
It does not matter. |
Thanks @nzola. This should hopefully help @mabuelhagag figure out his next steps. |
@nzola: Can you run |
@holta Done! |
FYI @mabuelhagag add |
No, I did not set the variable, should really be assigned by nzola to keep duplicates out of the picture when a request for the required auth-token is made. |
https://flask.palletsprojects.com/en/2.1.x/cli/#dotenv suggest that .flaskenv could hold the FLASK_APP= part but would need python-dotenv in the virtual environment, which looks to be installed, most likely dragged in by some other python library as a dependency.
|
Lokole 0.8.2 is now released. lokole_install: True
lokole_enabled: True
lokole_client_id: <client ID>
lokole_sim_type: Ethernet @jvonau @holta |
Ok I am going to test now. |
TASK [lokole : Create Lokole admin user with password, for http://box/lokole] ****************************************************************************************** TASK [lokole : SEE ERROR ABOVE (skip_role_on_error: False)] ************************************************************************************************************ PLAY RECAP ************************************************************************************************************************************************************* pi@raspberrypi:~ $ |
@mabuelhagag The install error I have posted here above had been fixed by you before. In fact this was the first problem you fixed when you joined the project. |
@nzola It seems that you're not using the PR code. curl iiab.io/install.txt | sudo bash -s 3276 |
@mabuelhagag You are right I used this curl iiab.io/install.txt | sudo bash instead |
No worries. |
@mabuelhagag if this PR #3276 is carefully tested to be safe to merge, please let us know, Thanks! |
@holta If Nzola reports back that it's working fine then we can merge. |
@mabuelhagag |
I have just finished testing Lokole email system. Client cannot register onto the main server |
Because the client cannot register to the main server, mail transaction doesn't flow between the client users and the internet email addresses. |
I have extensively tested Lokole email functionality under PR 3276 and the result is positive. |
I just got a message from @mabuelhagag saying merge this, so I'm doing that now, and further polish can be added later. Thanks to @jvonau who's helped along the way, keeping an eye on this. Related: |
Thank you guys for your support. Feel free to report any issues that might occur and assign it to me. |
I will run tests tonight when I return home after work.
…On Tue, Sep 27, 2022 at 6:40 AM Mohamad A. ***@***.***> wrote:
Thank you guys for your support. Feel free to report any issues that might
occur and assign it to me.
—
Reply to this email directly, view it on GitHub
<#3276 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEH5MMYHOK562L7KJUCW6OTWAL2LDANCNFSM52JYVPCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@mabuelhagag @jvonau @holta iiab install when very well nonstop from start to end. I selected size 1 install and it took about 45 minutes to complete on PI4 B 2 GIG. I used PI OS 64 bit Lite. |
Likely because you did not force a full SHIFT-reload (refresh) in your browser. Hold down the SHIFT key on your keyboard — as you click reload in your browser. (You need to clear your browser cache.) Use a completely different client device and completely different browser to verify. (As you can see below, the logo was changed in late August...) https://github.com/iiab-share/js-menu-files/blob/master/menu-defs/en-lokole.json https://github.com/iiab-share/js-menu-files/blob/master/images/lokole-logo-200x105.png |
Ok I see. I did not clear my browser after the 3276 merge and the new
install. I will give it a try when I return home after work.
Thanks @A Holt ***@***.***>
…On Wed, Sep 28, 2022 at 7:02 AM A Holt ***@***.***> wrote:
3 The Lokole newer logo does not show on the iiab main menu, only he old
generic logo
Likely because you did not force a full SHIFT-reload (refresh) in your
browser. Hold down the SHIFT key in your keyboard — as you click reload in
your browser. (You need to *clear your browser cache.*)
*Use a completely different client device and completely different browser
to verify.*
(As you can see below, the logo was changed in late August...)
https://github.com/iiab-share/js-menu-files/blob/master/menu-defs/en-lokole.json
https://github.com/iiab-share/js-menu-files/blob/master/images/lokole-logo-200x105.png
—
Reply to this email directly, view it on GitHub
<#3276 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEH5MM53GYZTGTDS5NEDPW3WARFYLANCNFSM52JYVPCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@holta |
@holta French bouquet install completed without any problem and nonstop from start to finish |
Fixes bug:
#2833,#2986, ascoderu/lokole#585
Description of changes proposed in this pull request:
/etc/iiab/local_vars.yml:
Smoke-tested on which OS or OS's:
Ubuntu 20.04 Server (Vagrant ubuntu/focal64 box)
Mention a team member @username e.g. to help with code review:
@jvonau @holta