Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infastructure for proper versioning. #2500

Merged
merged 9 commits into from
Sep 17, 2020
Merged

Conversation

jvonau
Copy link
Contributor

@jvonau jvonau commented Sep 2, 2020

Add the recording of IIAB_REVISION to stage 9 to allow incriminating the value to reflect major change in a role that would require a re-install where such roles would be recorded in upgrade_roles, works with iiab/iiab-factory#134

Change the value for any roles' source version that would require a re-install, that gets noted in upgrade_roles and iiab_revision gets bumped. The big mongodb change is a perfect test subject.

@holta holta added this to the 7.2 milestone Sep 2, 2020
@jvonau jvonau force-pushed the iiab-upgrade branch 2 times, most recently from af11aec to 581e67e Compare September 4, 2020 03:07
@jvonau
Copy link
Contributor Author

jvonau commented Sep 4, 2020

You see the release workflow going on here right?
make a change that requires a reinstall
bump iiab_revision
add iiab_revision number and role to upgrade_roles

134 has the logic in bash to remove the role based on upgrade_roles from the iiab_state.yml file just like runrole --reinstall does for a single role. Could be done in other places but lets start with this in place to have something to test against?

@jvonau jvonau mentioned this pull request Sep 4, 2020
@jvonau jvonau changed the title iiab-upgrade Infastructure for proper versioning. Sep 8, 2020
@jvonau
Copy link
Contributor Author

jvonau commented Sep 8, 2020

This PR was tagged with "question" a week ago, with no question asked. What is the deal here?

@holta
Copy link
Member

holta commented Sep 8, 2020

Let's surface exactly these design/architectural questions and needs for this PR and others (PR #2511 and others) during our Thursday 10AM NYC IIAB Calls (http://minutes.iiab.io) so everybody can understand where changes like this are critically important, how they serve specific implementer/field communities's needs, medium-term versus long-term etc.

All hugely important questions.

Keeping in mind that IIAB 7.2 should ship this month with very few changes, if possible (i.e. most all structural/design changes should really target IIAB 8.0 at this point). No rule is completely hard & fast -- but as stated at http://minutes.iiab.io -- we should try to keep those remaining IIAB 7.2 pre-release changes bounded in these 3 rough categories: (if at all possible!!)

@jvonau
Copy link
Contributor Author

jvonau commented Sep 8, 2020

The general idea is to use iiab_revision in conjunction with tagging|branching to denote an easy a point in time reference of the code-base without resorting to git hashes.

@holta holta modified the milestones: 7.2, 8.0 Sep 10, 2020
@jvonau
Copy link
Contributor Author

jvonau commented Sep 10, 2020

This goes into 7.2 or the freebies stop.

@jvonau jvonau force-pushed the iiab-upgrade branch 3 times, most recently from 693aa30 to 6297f40 Compare September 13, 2020 03:34
do_reinstall will denote a major upgrade path in the future
@tim-moody
Copy link
Contributor

is the proposal to track revisions by role or by entire install?

@jvonau
Copy link
Contributor Author

jvonau commented Sep 17, 2020

By the role

@georgejhunt georgejhunt merged commit 429aa04 into iiab:master Sep 17, 2020
holta added a commit that referenced this pull request Sep 17, 2020
@jvonau
Copy link
Contributor Author

jvonau commented Sep 17, 2020

@holta Get off your high horse you power freak.

@jvonau
Copy link
Contributor Author

jvonau commented Sep 18, 2020

Despite the childish attempt to block testing progress by reverting this commit /iiab/iiab-factory#134 proved to be a success http://sprunge.us/YlHp09 note the order of entries in /etc/iiab/iiab_state.yml the 3 roles were automatically upgraded as the new entries are below calibreweb_installed, the last role to possibly be installed on a machine that was first installed on July 20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants