Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show meetecho recordings for groups with more than one session #8238

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

rjsparks
Copy link
Member

Fixes #8236

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (c7f6bde) to head (031e000).
Report is 191 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8238      +/-   ##
==========================================
+ Coverage   88.78%   88.94%   +0.15%     
==========================================
  Files         296      303       +7     
  Lines       41320    41282      -38     
==========================================
+ Hits        36687    36718      +31     
+ Misses       4633     4564      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The only fault I see is the very opaque way that _format_materials() filters out non-Truthy materials, but that's for another day...

@rjsparks rjsparks merged commit bdf503a into ietf-tools:main Nov 19, 2024
9 checks passed
@rjsparks rjsparks deleted the multisessionrecording branch November 19, 2024 21:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proceedings only show one session recording link for groups that had multiple sessions at 121
2 participants