fix: show meetecho recordings for groups with more than one session #8238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8238 +/- ##
==========================================
+ Coverage 88.78% 88.94% +0.15%
==========================================
Files 296 303 +7
Lines 41320 41282 -38
==========================================
+ Hits 36687 36718 +31
+ Misses 4633 4564 -69 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jennifer-richards
approved these changes
Nov 19, 2024
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
lgtm. The only fault I see is the very opaque way that _format_materials() filters out non-Truthy materials, but that's for another day...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8236