fix: Agenda mobile goto now #8160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-richards
approved these changes
Nov 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8160 +/- ##
==========================================
+ Coverage 88.78% 88.92% +0.13%
==========================================
Files 296 304 +8
Lines 41320 41328 +8
==========================================
+ Hits 36687 36749 +62
+ Misses 4633 4579 -54 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change to the mobile menu days worked because there were ids in the page for days, but there wasn't an id in the page for 'now'.
jumpToDaywas never called so this adds an onClick handler to calljumpToDayas it was before.Also, because we're using links in the dropdown rather than buttons we need to manually show the dropdown, and there's code for that too.