Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Selenium tests via scroll_and_click #8150

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

holloway
Copy link
Contributor

@holloway holloway commented Nov 4, 2024

This PR...

  • Adds a utility scroll_and_click to force scrolling and clicking a specific element because Selenium has restrictions around clicking elements outside the viewport.
  • use that to fix those Selenium errors on GH CI.

@holloway holloway marked this pull request as ready for review November 4, 2024 15:30
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (c7f6bde) to head (c29a131).
Report is 168 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8150      +/-   ##
==========================================
+ Coverage   88.78%   88.92%   +0.13%     
==========================================
  Files         296      304       +8     
  Lines       41320    41328       +8     
==========================================
+ Hits        36687    36749      +62     
+ Misses       4633     4579      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit de49479 into ietf-tools:main Nov 5, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants