adding Send+Sync supertraits to BootstrapStore for smoother async exp… #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, if you are building a client (which it sounds like you are doing), you may want to ask to get it listed in the RDAP Guide. Thanks for the PR and if you have any other suggestions or ideas, please feel free to submit them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using the library in an async context (in a Tauri app within a
#[tauri:command]) and went through hell because the compiler complainedBootstrapStoredoesn't implementSend.I trivially modified the trait and its implementation (
MemoryBootstrapStore) to implement bothSendandSync.It works in my app and passes unit-tests.