New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect handling of loaded images #9

Merged

michalkouril merged 1 commit into iatgen:master from liadnac:image_load

Dec 16, 2021

Contributor

liadnac commented Apr 17, 2021

The check of loadedImages is incorrect which causes the imagesLoaded function to get called for every image.

Also setting the src field before onload is discouraged, see:
https://stackoverflow.com/questions/14648598/is-it-necessary-to-set-onload-function-before-setting-src-for-an-image-object


          fix incorrect handling of loaded images

3a5852d

michalkouril merged commit c2cf3c1 into iatgen:master

Member

michalkouril commented Dec 16, 2021

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet