chore(test): bump django-allauth to 0.62.1
#627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Author
|
Done in 3342e05. Where our changes diverge, I went with yours - that is: modified dj_rest_auth/tests/test_serializers.py
@@ -120,10 +120,7 @@ class TestSocialLoginSerializer(TestCase):
def setUpTestData(cls):
cls.request_data = {"access_token": "token1234"}
cls.request = APIRequestFactory().post(cls.request_data, format='json')
-
- middleware = SessionMiddleware(get_response=MagicMock())
- middleware(cls.request)
-
+ cls.request.session = {}
social_app = SocialApp.objects.create(
provider='facebook',
name='Facebook',
@@ -153,7 +150,7 @@ class TestSocialLoginSerializer(TestCase):
serializer.is_valid()
self.assertDictEqual(serializer.errors, self.NO_ADAPTER_CLASS_PRESENT)
- @patch('allauth.socialaccount.providers.facebook.views.FacebookOAuth2Adapter.complete_login')
+ @patch('allauth.socialaccount.providers.facebook.flows.complete_login')
@patch('allauth.socialaccount.adapter.DefaultSocialAccountAdapter.pre_social_login')
def test_immediate_http_response_error(self, mock_pre_social_login, mock_fb_complete_login):
dummy_view = SocialLoginView()All tests pass on 3342e05. |
|
@gekoke We also need this change: pennersr@4f6ca76 -- for the upcoming new allauth headless functionality several internals to which dj-rest-auth hooks up are changed. |
Author
|
Anything we can do to help expedite this PR? |
willing to help as well. |
Owner
|
Merged in latest changes and fixed linting error, but there are still some failing tests related to dependencies. |
Author
Author
|
Closing as obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps tests to support
django-allauth0.62.1.Also fixes some incidental test breakages that came with the version bump.
Fixes #626.