Check if the output is a tty#31
Merged
hykilpikonna merged 2 commits intohykilpikonna:masterfrom Oct 27, 2022
yxnan:master
Merged
Check if the output is a tty#31hykilpikonna merged 2 commits intohykilpikonna:masterfrom yxnan:master
hykilpikonna merged 2 commits intohykilpikonna:masterfrom
yxnan:master
Conversation
The color code should not be emitted if the stdout is not a typical terminal, we add the check so there is no need to explictly specify `--stdout`
hykilpikonna
requested changes
Oct 26, 2022
Contributor
Author
|
I think changing how the Despite having changed the default config, users who keep the older configs can still expect the program works exactly as before. |
hykilpikonna
approved these changes
Oct 27, 2022
Owner
That's a nice solution, thank you so much! |
teohhanhui
added a commit
to teohhanhui/hyfetch
that referenced
this pull request
Jul 19, 2024
Fix stray newlines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The color code should not be emitted if the stdout is not a typical terminal, we add the check so there is no need to explictly specify
--stdoutIssues
p-e-w/shin#3 (comment)