fix an issue with bash 5.2#24
Merged
hykilpikonna merged 1 commit intohykilpikonna:masterfrom Oct 4, 2022
Un1q32:master
Merged
Conversation
hykilpikonna
approved these changes
Oct 4, 2022
Owner
|
Sorry for the delay, I was waiting for ArchLinux to push the bash 5.2 update but it's still on 5.1.16 as of now, so I just compiled from source. Thank you for your contribution! Please make sure to attach a description of the issue in the future so we can know what issue it's fixing and what to test for. So this pull request fixes the issue that, on bash 5.2, neofetch outputs after the last line of the system informations would be cut off. Before fix:
After fix:
|
Owner
|
I found a bug 🐛 This change would introduce an issue for bash 3.2.57, where the [m at the end isn't processed:
Since macOS preinstalls bash 3.2.57, this would be impactful. I've added a check for bash 3 to fix this:
If you have better solutions, please let me know! |
This was referenced Nov 2, 2022
Open
This was referenced Nov 28, 2022
1 task
Merged
teohhanhui
added a commit
to teohhanhui/hyfetch
that referenced
this pull request
Jul 14, 2024
Implement select_lightness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.