Properly make use of the config file argument#177
Merged
hykilpikonna merged 1 commit intohykilpikonna:masterfrom Sep 7, 2023
Merged
Properly make use of the config file argument#177hykilpikonna merged 1 commit intohykilpikonna:masterfrom
hykilpikonna merged 1 commit intohykilpikonna:masterfrom
Conversation
hykilpikonna
approved these changes
Sep 7, 2023
Owner
|
Oops, thanks for catching this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Address the issue raised in #176, which is that -C was silently failing to load config files that were not in the default path. The problem was that
check_configwas checking that the path given in -C was a valid file, and then loading CONFIG_PATH instead, which was not being set to what was given in -C.This behavior is shown in the attached screenshot.
Relevant Links
#176
Screenshots
Before
After
