Fix broken 'for' loops in FindElements methods.

Previously the code was updating a copy of each element rather than the element in the array.
hupe1980 · Jul 8, 2024 · da40194 · da40194
1 parent 4d5165f
commit da40194
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/element.go b/element.go
@@ -74,9 +74,9 @@ func (e *Element) FindElements(strategy LocatorStrategy, selector string) ([]Ele
 		return nil, err
 	}
 
-	for _, element := range elements {
-		element.SessionID = e.SessionID
-		element.client = e.client
+	for index, _ := range elements {
+		elements[index].SessionID = e.SessionID
+		elements[index].client = e.client
 	}
 
 	return elements, nil

diff --git a/session.go b/session.go
@@ -300,9 +300,9 @@ func (s *Session) FindElements(strategy LocatorStrategy, selector string) ([]Ele
 		return nil, err
 	}
 
-	for _, element := range elements {
-		element.SessionID = s.ID
-		element.client = s.client
+	for index, _ := range elements {
+		elements[index].SessionID = s.ID
+		elements[index].client = s.client
 	}
 
 	return elements, nil

diff --git a/shadowroot.go b/shadowroot.go
@@ -45,9 +45,9 @@ func (s *ShadowRoot) FindElements(strategy LocatorStrategy, selector string) ([]
 		return nil, err
 	}
 
-	for _, element := range elements {
-		element.SessionID = s.ID
-		element.client = s.client
+	for index, _ := range elements {
+		elements[index].SessionID = s.ID
+		elements[index].client = s.client
 	}
 
 	return elements, nil