Skip to content

Conversation

@HMJ0628
Copy link
Contributor

@HMJ0628 HMJ0628 commented Dec 7, 2024

What does this PR do?

I have translated agents.md to Chinese. Please let me know if there are any corrections. Thank you very much!

issue:[i18n-] Translating docs to Chinese Translate agents.md into Chinese #35135
Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HMJ0628 HMJ0628 changed the title Translating agents.md to Chinese [i18n-<languageCode>] Translating agents.md to Chinese Dec 7, 2024
@Rocketknight1
Copy link
Member

cc @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! As a reminder, you'll also need someone to review the translated content (I can't read Chinese) 🤗

@stevhliu
Copy link
Member

Hi, no need to keep updating your branch!

@HMJ0628
Copy link
Contributor Author

HMJ0628 commented Dec 10, 2024

Hi, no need to keep updating your branch!

Excuse me,what should I do to ?

@HMJ0628
Copy link
Contributor Author

HMJ0628 commented Dec 10, 2024

Should I pull request again?

@stevhliu
Copy link
Member

You don't have to do anything! 🤗 Let the CI test below finish running and then I'll merge it for you!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, can you add agents to the toctree please?

@HMJ0628
Copy link
Contributor Author

HMJ0628 commented Dec 10, 2024

sorry,I have added agents to the toctree.

@stevhliu
Copy link
Member

stevhliu commented Dec 10, 2024

Great! Last step to resolve the error is to remove the transformers_agents.md file (this is outdated now) and replace it in the toctree with your new agents file

@HMJ0628
Copy link
Contributor Author

HMJ0628 commented Dec 10, 2024

OK, I have finished it.

@stevhliu
Copy link
Member

Last step to resolve the error is to remove the transformers_agents.md file (this is outdated now)

You still need to remove the transformers_agents.md file https://github.com/HMJ0628/transformers/blob/main/docs/source/zh/transformers_agents.md from your branch

@HMJ0628
Copy link
Contributor Author

HMJ0628 commented Dec 10, 2024

sorry, I have removed the file.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation! 🤗

@stevhliu stevhliu merged commit 10feacd into huggingface:main Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants