[WIP] Add flex attention for Qwen2VL #35112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jla524
changed the title
jla524
commented
Dec 7, 2024
| score += causal_mask[b][0][q_idx][kv_idx] | ||
| return score | ||
|
|
||
| attn_output, attn_weights = flex_attention( |
Contributor
Author
There was a problem hiding this comment.
I'm having a hard time getting tests to pass with flex attention.
Can I merge the refactor for now, and add flex attention as a follow up?
…ransformers into feat/refactor_qwen2vl_attention
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey sorry for the late review! We ended up refactoring the API a bit more and I was off for a week! 🤗
Hope we did not deter you from contributing, and thanks for opening the PR! 🤗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses #34809 (issue)
Who can review?
@ArthurZucker