-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AsyncTextIteratorStreamer for asynchronous streaming #34931
Open
CISC
wants to merge
18
commits into
huggingface:main
Choose a base branch
from
CISC:async-streamer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was missing autodoc entry. |
@gante @ArthurZucker Ready for review. The |
@ArthurZucker @gante ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asynchronous text generation streaming
Added a new
AsyncTextIteratorStreamer
class that allows you to have fully asynchronous text generation streaming in your application. Works identically toTextIteratorStreamer
except that you iterate the stream as follows:Requires Python 3.11+ due to use ofFalls back toasyncio.timeout
to handle timeout.asyncio.wait_for
ifasyncio.timeout
is not available.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Any hints on how best to implement an async test would be appreciated. :)pytest-asyncio seems to be the way to go...Who can review?
@gante @ArthurZucker