Update Mistral conversion script #34829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Nov 22, 2024
| parser.add_argument( | ||
| "--is_v3", action="store_true", help="Whether the checkpoints correspond to the 3rd version or not." | ||
| "--modules_are_split", |
There was a problem hiding this comment.
equivalent to is v3 no?
There was a problem hiding this comment.
Yes, but it's actually the opposite (is_v3 = not modules_are_split) because this corresponds to an old case, so I switched the default which makes much more sense now. But I can revert if needed
|
IMO it makes more sense now (the keyword is more descriptive, and this case is very unlikely to reappear in future conversions), but I can revert if you think it can break some backward stuff! 🤗 |
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
* Update convert_mistral_weights_to_hf.py * Update convert_mistral_weights_to_hf.py * Update convert_mistral_weights_to_hf.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update/refactor Mistral conversion script to work with latest models.
cc @ArthurZucker