Drop Support for [email protected]
#698
Conversation
seanpdoyle
force-pushed
the
drop-support-for-ruby-2
branch
5 times, most recently
from
1035891 to
600f23f
Compare
seanpdoyle
force-pushed
the
drop-support-for-ruby-2
branch
3 times, most recently
from
251dbbc to
e7a8848
Compare
Commit to requiring `[email protected]` Remove `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and `[email protected]` from the CI matrix, along with any `RUBY_VERSION < "3"` conditionals. The implementation changes include replace older syntaxes with newer variants. For example, utilize `...` in place of `*args, &block`, rely on `**`-ing attribute `Hash` arguments, etc.
seanpdoyle
force-pushed
the
drop-support-for-ruby-2
branch
from
e7a8848 to
79f7cce
Compare
|
@jorgemanrubia I've rebased off Does this changeset achieve the same outcome as https://github.com/hotwired/turbo-rails/tree/fix-tests? If not, maybe you can cherry-pick the changes necessary to pass CI. |
|
Lovely, thanks @seanpdoyle! I had started to look into fixing the tests, I didn't realize you had this one open 🙏 |
|
FYI (for future readers), this being a patch version change broke our build unexpectedly (of course caught by CI, so impact minimal). This release increased the minimum Rails version to 7.1, which is not yet in Debian (stable). If you are on Debian 12, pin to v2.0.12, or vendor it. In fact you can grab v2.0.13 and manually edit the For those thinking that Rails 6.1 / 7.0 are EOL, the Ruby Debian team is still backporting bugfixes, as is the promise for all things Ruby in Debian. |
Related to #681
Follow-up to #682
Commit to requiring
[email protected]Remove
[email protected],[email protected],[email protected],[email protected], and[email protected]from the CI matrix, along with anyRUBY_VERSION < "3"conditionals.The implementation changes include replace older syntaxes with newer variants. For example, utilize
...in place of*args, &block, rely on**-ing attributeHasharguments, etc.