Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about overwriting layout resolution and turbo frame requests #470

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

cice
Copy link
Contributor

@cice cice commented Jun 5, 2023

Closes #268

Hi,
since we also ran into the issue of using Turbo-Frames with custom layouts, I took the liberty to draft an extension to the Readme to cover this topic.
I am neither a native english speaker, nor an experienced tech/documentation writer, so feel free to correct/extend/rewrite.
cheers,
Marian

@dhh dhh merged commit 50f2c67 into hotwired:main Jun 20, 2023
@aaronjensen
Copy link
Contributor

Does this result in no layout being set? Isn't that different than

layout -> { "turbo_rails/frame" if turbo_frame_request? }

@cice
Copy link
Contributor Author

cice commented Jun 20, 2023

Does this result in no layout being set? Isn't that different than

layout -> { "turbo_rails/frame" if turbo_frame_request? }

That is a valid point. Apparently this was changed (more or less) recently: #428

@cice cice deleted the patch-1 branch June 20, 2023 14:22
@dhh
Copy link
Member

dhh commented Jun 20, 2023

Wups, yes, true. @cice can you update docs to match #428?

@cice
Copy link
Contributor Author

cice commented Jun 20, 2023

Wups, yes, true. @cice can you update docs to match #428?

yes, will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Layout not omitted for turbo frames when using custom layout
3 participants