HSB-499 feat: env file sync with infra config #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewBastin
force-pushed
the
feat/infra-config-sync-env-file
branch
from
4c0b8d8 to
d597b95
Compare
AndrewBastin
approved these changes
Nov 26, 2024
jamesgeorge007
force-pushed
the
feat/infra-config-sync-env-file
branch
from
d597b95 to
db770c3
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HSB-499
What's changed
This PR adds synchronization if
.envchanges later on.With these benefits, the end user can change any variables (i.e. SSO Secrets, ClickHouse configs, etc) either from Admin Dashboard or
.envfile, both will be synced and take the latest updates' value.Notes to reviewers
Nil
Documentation updates
We can remove this Hard reset Configuration Docs