chore: continue openapi imports on error with a partial import #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
previously approved these changes
Nov 22, 2024
jamesgeorge007
dismissed
their stale review
Just noticed a change in behavior about permitting invalid OpenAPI documents although it won't result in new collection entries.
jamesgeorge007
approved these changes
Nov 25, 2024
jamesgeorge007
force-pushed
the
fix/continue-import-on-error-openapi
branch
from
c1333d5
to
668027d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixs HFE-659
Before
If validating an openapi failed, we abort the entire import and shows an error message.
After
If the validation failed, but there's a schema available with the error, we import that instead of entirely breaking the import