hotfix: graphql connection error handler #4523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
requested changes
Nov 8, 2024
jamesgeorge007
requested changes
Nov 11, 2024
There was a problem hiding this comment.
-
The
Browser extensionis not installed and set as the active interceptor, the corresponding error state isn't displayed in the response section.
-
For the error toast displayed when the introspection attempt fails while attempting to connect, we'll have to exclude it for the case when
Browser extensionis the active interceptor where the message displayed saysHeading not found. Also, since a connection attempt is performed while sending a request, currently it results in an error toast due to the introspection query failing following a success toast saying the query succeeded in the given time frame and might not be necessary in such a case.
jamesgeorge007
approved these changes
Nov 11, 2024
AndrewBastin
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the error handling for GraphQL connections. It adds a new error message for HTTP errors and updates the connection state to "ERROR" when an HTTP error occurs.
Context: Previously, attempting to send a request would toggle the connection state reflecting in the
Connectbutton. However, the schema fetch doesn't happen, and the request goes through regardless of whether the introspection attempt fails. With #4516, the schema fetch attempt takes place before sending a request and a failure in this phase would affect the overall request execution flow. With the proposed changes, the introspection query (schema fetch) failing with a non-200status code is accounted for with relevant error handlers ensuring the request execution goes through even if the schema fetch attempt fails.